• Dibyendu Majumdar (6/6) May 14 2019 Hi,
• Nicholas Wilson (11/17) May 14 2019 As a reviewer I much prefer smaller PRs, not so much because they
• Andrei Alexandrescu (2/8) May 14 2019 Small and meaningful is beautiful.

Dibyendu Majumdar <d.majumdar gmail.com> writes:

Hi,

I would prefer to submit small pull requests that do not take 
much time to review and can be merged quickly - and this way work 
through the spec. Is this okay or is it better to make large pull 
requests with a whole bunch of changes?

Thanks

Nicholas Wilson <iamthewilsonator hotmail.com> writes:

On Tuesday, 14 May 2019 at 21:27:23 UTC, Dibyendu Majumdar wrote:
 Hi,

 I would prefer to submit small pull requests that do not take 
 much time to review and can be merged quickly - and this way 
 work through the spec. Is this okay or is it better to make 
 large pull requests with a whole bunch of changes?

 Thanks

As a reviewer I much prefer smaller PRs, not so much because they 
are easier to review (I mean its nice, don't get me wrong) but 
the error messages you get if you muck something up are much 
easier to pinpoint in smaller PRs.

You can get most of the benefits of larger PRs from telling the 
reviewers what you're woking on an what they can expect to come 
next. If for some reason that doesn't work submitting multiple 
PRs that split the changes is also a good option.

Thanks
Nic

Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:

On 5/14/19 10:27 PM, Dibyendu Majumdar wrote:
 Hi,
 
 I would prefer to submit small pull requests that do not take much time 
 to review and can be merged quickly - and this way work through the 
 spec. Is this okay or is it better to make large pull requests with a 
 whole bunch of changes?

Small and meaningful is beautiful.