digitalmars.D.learn - Perhaps I'm just a bit pushie
- Danny Arends (18/18) Oct 27 2013 Hey there,
- Jonathan M Davis (9/30) Oct 27 2013 It varies considerably how long it takes for things to get merged. Somet...
Hey there, I was just wondering how long it takes for a pull request to get merged... I know that if its very controversial it can take weeks, but well I've submitted a minor patch to change some errors into exceptions (and add a more explanatory error msg)... https://github.com/D-Programming-Language/phobos/pull/1659 I know the alloca calls in there are troublesome but the behavior doesn't change (except for the fact that now on alloca failure, a better error is thrown) See: https://github.com/D-Programming-Language/phobos/pull/1659 Perhaps I'm just pushie, but well its my first pull request and would love to see my web server return some 'meaningful exception' from the standard library. No offense, you're all doing a great job with D Gr, Danny Arends http://www.dannyarends.nl/
Oct 27 2013
Jonathan M Davis <jmdavisProg gmx.com> On Sunday, October 27, 2013 20:17:48 Danny Arends wrote:Hey there, I was just wondering how long it takes for a pull request to get merged... I know that if its very controversial it can take weeks, but well I've submitted a minor patch to change some errors into exceptions (and add a more explanatory error msg)... https://github.com/D-Programming-Language/phobos/pull/1659 I know the alloca calls in there are troublesome but the behavior doesn't change (except for the fact that now on alloca failure, a better error is thrown) See: https://github.com/D-Programming-Language/phobos/pull/1659 Perhaps I'm just pushie, but well its my first pull request and would love to see my web server return some 'meaningful exception' from the standard library. No offense, you're all doing a great job with DIt varies considerably how long it takes for things to get merged. Sometimes it's fairly quick, but often it takes a while. The reasons for it vary, but it generally revolves around the fact that everyone working on D is a volunteer and manpower or availability can become a problem (though if something is controversial, that certainly doesn't help). The fact that pull requests aren't generally merged faster is on of the things that really worries Andrei and that he's brought up several times. We'd like to do better. - Jonathan M Davis
Oct 27 2013