www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.learn - Code Review

reply Venkat <venkatram.akkineni gmail.com> writes:
Can anybody take a look at this checkin ? The import files are a 
noise, please ignore them and take a look at the *.d files.

Changes I made.
- Tried to remove __va_argsave as it doesn't compile with it.
- Tried to replace no arg opCall() with a factory function.

https://bitbucket.org/vra5107/djni/pull-requests/1/code-now-compiles-removed-__va_argsave-and/diff


Thanks in advance
Venkat
Dec 09 2017
parent Venkat <venkatram.akkineni gmail.com> writes:
On Sunday, 10 December 2017 at 07:03:30 UTC, Venkat wrote:
 Can anybody take a look at this checkin ? The import files are 
 a noise, please ignore them and take a look at the *.d files.

 Changes I made.
 - Tried to remove __va_argsave as it doesn't compile with it.
 - Tried to replace no arg opCall() with a factory function.

 https://bitbucket.org/vra5107/djni/pull-requests/1/code-now-compiles-removed-__va_argsave-and/diff


 Thanks in advance
 Venkat
I should add that the source builds fine and I was able to write a couple of rudimentary programs using the library built from the sources.
Dec 09 2017