www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.ldc - Change hardcoded path to tzdata directory

reply Thomas Mader <thomas.mader gmail.com> writes:
Hello,

I added the TZ_DATABASE_DIR option to the Phobos Makefile to 
change the hardcoded path in the code with 
https://github.com/dlang/phobos/pull/5966.
Is LDC using this Makefile to build Phobos and is it possible to 
specify that option in the LDC build somehow or do I need to 
implement a solution for LDC too?

Thomas
Dec 22 2018
parent reply kinke <noone nowhere.com> writes:
On Saturday, 22 December 2018 at 16:51:27 UTC, Thomas Mader wrote:

 Is LDC using this Makefile to build Phobos


Nope.


 is it possible to specify that option in the LDC build somehow 
 or do I need to implement a solution for LDC too?


You can add arbitrary LDC compile flags for druntime/Phobos via 
`-DD_FLAGS=...` in the CMake command line, no need to hack a 
Makefile.
Your PR was merged into master, not stable, which means chances 
are this isn't going to land before 2.085, so you'll have to 
adapt LDC's Phobos until then.
Dec 22 2018
parent reply Petar Kirov [ZombineDev] <petar.p.kirov gmail.com> writes:
On Saturday, 22 December 2018 at 17:55:25 UTC, kinke wrote:

 [..]
 
 Your PR was merged into master, not stable, which means chances 
 are this isn't going to land before 2.085, so you'll have to 
 adapt LDC's Phobos until then.


That change was merged quite a while ago, so it was part of DMD 
2.079 and LDC 1.9 - see: 
https://github.com/ldc-developers/phobos/commit/735b360c4215720adf3b64b76c274ce1094538f9#diff-fdecdaf8196f65e06e550af5fd31a088.

On related note, I have observed several times at least where 
changes to the build system upstream weren't propagated 
downstream to GDC and LDC as you guys are using different build 
systems. The -dipxxxx and -transition=xxxxx flags look like 
future trouble maker candidates. Any suggestions how we could 
make this easier for you?
Dec 23 2018
parent kinke <noone nowhere.com> writes:
On Sunday, 23 December 2018 at 22:40:38 UTC, Petar Kirov 
[ZombineDev] wrote:

 That change was merged quite a while ago, so it was part of DMD 
 2.079 and LDC 1.9


Ah yeah, I only noticed December [2017] and thought it was 
brand-new. ;)


 On related note, I have observed several times at least where 
 changes to the build system upstream weren't propagated 
 downstream to GDC and LDC as you guys are using different build 
 systems. The -dipxxxx and -transition=xxxxx flags look like 
 future trouble maker candidates. Any suggestions how we could 
 make this easier for you?


-dip already was IIRC. Don't you have a file with a list of files 
to be compiled with DIP1008 or something? ;)

I surely don't want to step down to Makefiles. E.g., with CMake 
we don't have to maintain a (or actually, multiple) Makefiles 
whenever adding, removing or moving some module (although I guess 
that'd be possible with Makefiles too). And there's quite a lot 
of LDC specifics, for cross-compilation, LTO etc.

We have the testsuite at least, so something breaking can hardly 
be missed. Good test coverage is the best way to catch our 
attention.
Dec 23 2018