• d-bugmail puremagic.com (27/28) May 19 2022 https://issues.dlang.org/show_bug.cgi?id=23125

d-bugmail puremagic.com writes:

https://issues.dlang.org/show_bug.cgi?id=23125

          Issue ID: 23125
           Summary: Missing const in IIDFromString() in
                    core.sys.windows.objbase.d
           Product: D
           Version: D2
          Hardware: x86
                OS: Windows
            Status: NEW
          Severity: minor
          Priority: P1
         Component: druntime
          Assignee: nobody puremagic.com
          Reporter: info elkpoint.co.uk

DMD 2.099.0 on Windows 10

In core.sys.windows.objbase.d

HRESULT IIDFromString(LPOLESTR, LPIID);

From Win32 SDK (10.0.19041.0), combaseapi.h file dated 1-Dec-20:

_Check_return_ WINOLEAPI
IIDFromString(
    _In_ LPCOLESTR lpsz,
    _Out_ LPIID lpiid
    );

https://docs.microsoft.com/en-us/windows/win32/api/combaseapi/nf-combaseapi-iidfromstring

The D implementation has lost the const on the first parameter (LPOLESTR vs
LPCOLESTR).

This may also be true of other function declarations, but I haven't checked.

--