www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 12178] New: ddoc arbitrarily injects tabs instead of spaces in the output

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178

           Summary: ddoc arbitrarily injects tabs instead of spaces in the
                    output
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: ddoc
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: andrej.mitrovich gmail.com



03:49:32 PST ---
Created an attachment (id=1324)
image

Note the space before the first "opt", and before and after the second "opt",
it's a tab instead of a space. It makes the docs look long and ugly.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 15 2014
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Kenji Hara <k.hara.pg gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




 Created an attachment (id=1324) [details]
 image
 
 Note the space before the first "opt", and before and after the second "opt",
 it's a tab instead of a space. It makes the docs look long and ugly.
That's word wrapping of your browser view. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ddoc                        |
             Status|RESOLVED                    |REOPENED
          Component|DMD                         |websites
         Resolution|INVALID                     |



02:40:16 PST ---

 That's word wrapping of your browser view.
It's still an issue, even if not a ddoc issue. I'm retagging it as a website issue. The documentation should look nice regardless of the browser you're using. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178






 That's word wrapping of your browser view.
It's still an issue, even if not a ddoc issue. I'm retagging it as a website issue. The documentation should look nice regardless of the browser you're using.
I'm not sure it is an issue. It might always occur with long declaration signatures. For example: /// long function signature void aLongLong_tooLongFunctionIdentifier(LongLongParameterType1 longLongParameterName1, LongLongParameterType2 longLongParameterName2, LongLongParameterType3 longLongParameterName3, ...); -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




04:42:25 PST ---
Created an attachment (id=1325)
test2

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




04:42:59 PST ---

 Created an attachment (id=1325) [details]
 test2
This is what I think is a reasonable look. IOW I don't see why the excessive whitespace was added between parameters, it looks really odd in picture 1. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178






 Created an attachment (id=1325) [details] [details]
 test2
This is what I think is a reasonable look. IOW I don't see why the excessive whitespace was added between parameters, it looks really odd in picture 1.
So it's style issue. It will be fixed by: dlang.org/css/style.css .d_decl { font-weight: bold; background-color: #E4E9EF; /* border-top: solid black 1px; */ padding: 2px 0px 2px 2px; text-align: left; // <---- added } -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrei erdani.com,
                   |                            |andrej.mitrovich gmail.com



05:16:49 PST ---

 So it's style issue. It will be fixed by:
 
 dlang.org/css/style.css
 
 .d_decl {
     font-weight: bold;
     background-color: #E4E9EF;
     /* border-top: solid black 1px; */

     padding: 2px 0px 2px 2px;
     text-align: left;   // <---- added
 }
Thanks. As long as others agree they want this we could make the change. I don't want to impose my style over anyone elses. CC'ing Andrei. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




PST ---
Yes, that text should not be justified. I wanted to fix that since forever but
didn't get to it. Could you please submit a pull request?

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Kenji Hara <k.hara.pg gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull



https://github.com/D-Programming-Language/dlang.org/pull/501

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




Commits pushed to master at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/7bb40822806a28f6d46c4906d4200decf45ccfe7
fix Issue 12178 - Odd whitespace look on dlang website

https://github.com/D-Programming-Language/dlang.org/commit/b5d8cfca09696cbb0477621322ced83566c1094f


Issue 12178 - Odd whitespace look on dlang website

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrei Alexandrescu <andrei erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




Commit pushed to 2.065 at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/40ca19804e8899934aa3dd0a01e169916784ceb2


Issue 12178 - Odd whitespace look on dlang website

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 23 2014
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178




Commit pushed to master at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/40ca19804e8899934aa3dd0a01e169916784ceb2


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 23 2014