www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 11854] New: Git-head does not build with Visual Studio

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11854

           Summary: Git-head does not build with Visual Studio
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: regression
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: andrej.mitrovich gmail.com



08:18:55 PST ---

 1>mars.c(97): fatal error C1189: #error :  "fix this"


Specifically:

-----
#if TARGET_WINDOS
    obj_ext  = "obj";
#elif TARGET_LINUX || TARGET_OSX || TARGET_FREEBSD || TARGET_OPENBSD ||
TARGET_SOLARIS
    obj_ext  = "o";
#else
#error "fix this"
#endif
-----

IIRC I saw a recent pull pushing the TARGET_WINDOS define somewhere into a
makefile, so the visual studio project file should likely add this define too.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 31 2013
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11854




08:23:57 PST ---


 so the visual studio project file should likely add this define too.


Specifically it's added via (taken from
http://msdn.microsoft.com/en-us/library/hhzbb5c8.aspx):

    Open the project Property Pages dialog box. For more information, see How
to: Open Project Property Pages.

    In the left pane, select Configuration Properties, C/C++, Preprocessor.

    In the right pane, in the right-hand column of the Preprocessor Definitions
property, open the drop-down menu and choose Edit.

    In the Preprocessor Definitions dialog box, add (one per line), modify, or
delete one or more definitions. Choose OK to save your changes.

Note that each definition goes on its own line rather than being separated by a
space (silly VS make-me-think design..).

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 31 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11854




08:31:30 PST ---
https://github.com/D-Programming-Language/dmd/pull/3053

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 31 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11854




Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/e5d5d6e4c8a28fdc4d90e29e17bb4c5efbc491cc
Fix Issue 11854 - VS Project file missing a define.

https://github.com/D-Programming-Language/dmd/commit/34fc8dd50854a1ac1c1862ddadb2df2a33bf241e


Issue 11854 - VS Project file missing a define.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 31 2013
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11854


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |bugzilla digitalmars.com
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 31 2013