digitalmars.D.bugs - [Issue 10973] New: emplace internal error
- d-bugmail puremagic.com (40/40) Sep 05 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (7/7) Sep 06 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (12/14) Oct 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (17/17) Oct 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (11/23) Oct 20 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (13/13) Oct 20 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
- d-bugmail puremagic.com (7/7) Oct 20 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10973
http://d.puremagic.com/issues/show_bug.cgi?id=10973
Summary: emplace internal error
Product: D
Version: D2
Platform: All
OS/Version: All
Status: NEW
Severity: regression
Priority: P2
Component: Phobos
AssignedTo: monarchdodra gmail.com
ReportedBy: monarchdodra gmail.com
Conditions: Use aggregate initialization on a structure that has a static
array, while making the argument an element type of the array. EG:
//----
import std.conv;
struct S
{
int i;
int[2] ii;
}
void main()
{
S s = S(1, 2); //OK
emplace(&s, 1, 2); //Chokes
}
//----
The issue is in "emplacePostblitter", which is confused when it is asked to
postblit a type over something that isn't the same type.
"Luckilly", compilation stops, instead of potentially doing wrong code.
On topic, I'm really not a huge fan of "S s = S(1, 2); //OK": This is basically
implicit promotion from "int" to "int[2]". D usually bans implicit pormotion,
and *every time* I have seen this "aggregate initialization with static array
promotion" "feature" I (and others on the boards) have been surprised by it.
Introduced by pull:
https://github.com/D-Programming-Language/phobos/pull/1082
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 05 2013
d-bugmail puremagic.com http://d.puremagic.com/issues/show_bug.cgi?id=10973 While I am at it: emplacePostblitter does not correctly handle class types either, if one of the nested members is a class. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Sep 06 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10973
Walter Bright <bugzilla digitalmars.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bugzilla digitalmars.com
02:12:00 PDT ---
Introduced by pull:
https://github.com/D-Programming-Language/phobos/pull/1082
It's getting close to beta time. We should either revert this pull to fix the
regression, or fix it.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10973 Hum. I forgot to link back. First, this is a trivial reformat: https://github.com/D-Programming-Language/phobos/pull/1552 Then, this fixes the issues 10973 and 10978: https://github.com/D-Programming-Language/phobos/pull/1567 In parallel: This adds only extra unittests, that proves "array" works better than before: https://github.com/D-Programming-Language/phobos/pull/1528 This fixes "appender" to correctly use emplace, which fixes a bug we are regularly hitting: https://github.com/D-Programming-Language/phobos/pull/1529 It just needs some reviewing now. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Oct 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10973Hum. I forgot to link back. First, this is a trivial reformat: https://github.com/D-Programming-Language/phobos/pull/1552PulledThen, this fixes the issues 10973 and 10978: https://github.com/D-Programming-Language/phobos/pull/1567Relocated: https://github.com/D-Programming-Language/phobos/pull/1629In parallel: This adds only extra unittests, that proves "array" works better than before: https://github.com/D-Programming-Language/phobos/pull/1528PulledThis fixes "appender" to correctly use emplace, which fixes a bug we are regularly hitting: https://github.com/D-Programming-Language/phobos/pull/1529Still open. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Oct 20 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10973
David Nadlinger <code klickverbot.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |code klickverbot.at
Resolution| |FIXED
PDT ---
Merged:
https://github.com/D-Programming-Language/phobos/commit/edf906bc7f88c958ef6e5a7c391b5b76d7aa1779
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 20 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10973 PDT --- https://github.com/D-Programming-Language/phobos/pull/1629 https://github.com/D-Programming-Language/phobos/commit/edf906bc7f88c958ef6e5a7c391b5b76d7aa1779 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Oct 20 2013