digitalmars.D.bugs - [Patch] phobos: replaced printf with writef
- Thomas Kuehne (255/255) Oct 06 2004 Replaced printf with writef in the release code of phobos. Most unittest...
- Ben Hinkle (6/14) Oct 06 2004 shouldn't
- Stewart Gordon (5/21) Oct 06 2004 What's wrong with
- Ben Hinkle (6/32) Oct 06 2004 I haven't actually tried it but yeah that might work as long as there ar...
- Stewart Gordon (18/28) Oct 06 2004 Oops, that wasn't what I meant to say.
- Thomas Kuehne (3/15) Oct 07 2004 I forgot that :O
- Derek (9/35) Oct 06 2004 The first parameter is supposed to be a template or pattern, thus if 'ms...
Replaced printf with writef in the release code of phobos. Most unittests
still remain to be converted.
Note: if you haven't applied the patch from digitalmars.com
digitalmars.D.bugs:2025 you'll have to fix some chunks(missing "private"
keyword).
Thomas
begin 666 phobos__substitute_printf_with_writef.diff
M9&EF9B M=7( 9&UD+W-R8R]P:&]B;W,O:6YT97)N86PO9&UA:6XR+F0 9&UD
M+W-R8R]P:&]B;W-?;F5U+VEN=&5R;F%L+V1M86EN,BYD"BTM+2!D;60O<W)C
M.PT*+7!R:79A=&4 :6UP;W)T('-T9"YC+G-T9&EO.PT**W!R:79A=&4 :6UP
M;W)T('-T9"YS=&1I;SL-"B!P<FEV871E(&EM<&]R="!S=&0N8RYS=&1L:6([
M?0T*3G5R(&EN(&1M9"]S<F,O<&AO8F]S7VYE=2]I;G1E<FYA;#H 9&UA:6XR
M+F1^+ ID:69F("UU<B!D;60O<W)C+W!H;V)O<R]I;G1E<FYA;"]O8FIE8W0N
M9"!D;60O<W)C+W!H;V)O<U]N974O:6YT97)N86PO;V)J96-T+F0*+2TM(&1M
M:6YT97)N86PO;V)J96-T+F0),C P-"TQ,"TP-B P,CHR-3HQ,BXU-S(Q-3DY
M.PT*+2 ("!I;G0 =W!R:6YT9BAW8VAA<B J+" N+BXI.PT*+7T-"BMP<FEV
M(" >PT*+0EP<FEN=&8H(B4N*G-<;B(L('1O4W1R:6YG*"DI.PT**PEW<FET
M968H=&]3=')I;F<H*2PB7&XB*3L-"B (" ?0T*( T*(" ("!C:&%R6UT
M=W)I=&5F*&US9RPB7&XB*3L-"B (" ?0T*( T*(" ("!C:&%R6UT =&]3
M=')I;F<H*2![(')E='5R;B!M<V<[('T-"F1I9F8 +75R(&1M9"]S<F,O<&AO
M8F]S+W-T9"]C;VYV+F0 9&UD+W-R8R]P:&]B;W-?;F5U+W-T9"]C;VYV+F0*
M+2TM(&1M9"]S<F,O<&AO8F]S+W-T9"]C;VYV+F0),C P-"TP.2TR,2 Q.3HQ
M-#HU.
M"D! ("TQ,2PV("LQ,2PW($! "B -"B O+V1E8G5G/6-O;G8["0DO+R!U;F-O
M;6UE;G0 =&\ ='5R;B!O;B!D96)U9V=I;F< <')I;G1F)W,-"B -"BMP<FEV
M=&8H(F-O;G8N=&]);G0N=6YI='1E<W1<;B(I.PT**R ("!D96)U9RAC;VYV
M*2!W<FET968H(F-O;G8N=&]);G0N=6YI='1E<W1<;B(I.PT*( T*(" ("!I
M8V]N=BYT;U5I;G0N=6YI='1E<W1<;B(I.PT**R ("!D96)U9RAC;VYV*2!W
M<FET968H(F-O;G8N=&]5:6YT+G5N:71T97-T7&XB*3L-"B -"B (" =6EN
M("!I(#T
M?0T*( EC871C:" H17)R;W( 92D-"B )>PT*0$ +3,R-RPW("LS,C L-R!
M8V]N=BYT;TQO;F<N=6YI='1E<W1<;B(I.PT**R ("!D96)U9RAC;VYV*2!W
M<FET968H(F-O;G8N=&],;VYG+G5N:71T97-T7&XB*3L-"B -"B (" ;&]N
M("!I(#T
M?0T*( EC871C:" H17)R;W( 92D-"B )>PT*0$ +30S-BPW("LT,S<L-R!
M8V]N=BYT;U5L;VYG+G5N:71T97-T7&XB*3L-"BL (" 9&5B=6<H8V]N=BD
M=W)I=&5F*")C;VYV+G1O56QO;F<N=6YI='1E<W1<;B(I.PT*( T*(" ("!U
M"2 ("!I(#T =&]5;&]N9RAE<G)O<G-;:ETI.PT*+0D (" <')I;G1F*")I
M(#T )61<;B(L(&DI.PT**PD (" =W)I=&5F*")I(#T (BP :2P (EQN(BD[
M;G8I('=R:71E9B B8V]N=BYT;U-H;W)T+G5N:71T97-T7&XB*3L-"B -"B
M>PT*( D (" :2 ]('1O4VAO<G0H97)R;W)S6VI=*3L-"BT)(" ('!R:6YT
M9B B:2 ]("5D7&XB+"!I*3L-"BL)(" ('=R:71E9B B:2 ]("5D7&XB+"!I
M*3L-"B )?0T*( EC871C:" H17)R;W( 92D-"B )>PT*0$ +38P."PW("LV
M,#DL-R
M('!R:6YT9B B:2 ]("5D7&XB+"!I*3L-"BL)(" ('=R:71E9B B:2 ]("5D
M7&XB+"!I*3L-"B )?0T*( EC871C:" H17)R;W( 92D-"B )>PT*0$ +38X
M."PW("LV.#DL-R
M;G8I('!R:6YT9B B8V]N=BYT;T)Y=&4N=6YI='1E<W1<;B(I.PT**R ("!D
M96)U9RAC;VYV*2!W<FET968H(F-O;G8N=&]">71E+G5N:71T97-T7&XB*3L-
M+" B7&XB*3L-"B )?0T*( EC871C:" H17)R;W( 92D-"B )>PT*0$ +3<W
M;G8I('!R:6YT9B B8V]N=BYT;U5B>71E+G5N:71T97-T7&XB*3L-"BL ("
M9&5B=6<H8V]N=BD =W)I=&5F*")C;VYV+G1O56)Y=&4N=6YI='1E<W1<;B(I
M.PT*( T*(" ("!U8GET92!I.PT*( T*0$ +3 Q.2PW("LX,C L-R! 0 H
M(" <')I;G1F*")I(#T )61<;B(L(&DI.PT**PD (" =W)I=&5F*")I(#T
M<U]N974O<W1D+VUD-2YD"BTM+2!D;60O<W)C+W!H;V)O<R]S=&0O;60U+F0)
M,C P-"TQ,"TP-B P,CHR,#HT-
M<F,O<&AO8F]S7VYE=2]S=&0O;60U+F0),C P-"TQ,"TP-B P,CHR-3HQ,BXU
M.PD)+R\ =6YC;VUM96YT('1O('1U<FX ;VX 9&5B=6=G:6YG('!R:6YT9B=S
M=$1I9V5S="AU8GET92!D:6=E<W1;,39=*0T*('L-"B (" 9F]R96%C:" H
M=6)Y=&4 =3L 9&EG97-T*0T*+0EP<FEN=&8H(B4P,G B+"!U*3L-"BL)=W)I
M(&1E8G5G*&UD-2D =W)I=&5F*")S=&0N;60U+G5N:71T97-T7&XB*3L-"B -
M"B (" =6)Y=&5;,39=(&1I9V5S=#L-"B -"DYU<B!I;B!D;60O<W)C+W!H
M+W-T9"]M;69I;&4N9"!D;60O<W)C+W!H;V)O<U]N974O<W1D+VUM9FEL92YD
M"BTM+2!D;60O<W)C+W!H;V)O<R]S=&0O;6UF:6QE+F0),C P-"TP.2TR,2 Q
M.3HQ-#HU.
M=2]S=&0O;6UF:6QE+F0),C P-"TQ,"TP-B P,CHR-3HQ,BXU-S,Q-3DW-C
M:79A=&4 :6UP;W)T('-T9"YF:6QE.PHM<')I=F%T92!I;7!O<G0 <W1D+F,N
M<W1D:6\["BMP<FEV871E(&EM<&]R="!S=&0N<W1D:6\["B!P<FEV871E(&EM
M<&]R="!S=&0N8RYS=&1L:6(["B!P<FEV871E(&EM<&]R="!S=&0N<&%T:#L*
M0$ *( D)9F0 /2!S=&0N8RYL:6YU>"YL:6YU>"YO<&5N*&YA;65Z+"!O9FQA
M9RP 9FUO9&4I.PH "0EI9B H9F0 /3T +3$I"B )"7L*+0D)(" ('!R:6YT
M9B B7'1O<&5N(&5R<F]R+"!E<G)N;R ]("5D7&XB+&=E=$5R<FYO*"DI.PHK
M"0D (" =W)I=&5F*")<=&]P96X 97)R;W(L(&5R<FYO(#T (BP 9V5T17)R
M;F\H*2P (EQN(BD["B )"2 ("!E<G).;R I.PH "0E]"B *9&EF9B M=7(
M9&UD+W-R8R]P:&]B;W,O<W1D+V]U=&]F;65M;W)Y+F0 9&UD+W-R8R]P:&]B
M;W-?;F5U+W-T9"]O=71O9FUE;6]R>2YD"BTM+2!D;60O<W)C+W!H;V)O<R]S
M*W!R:79A=&4 :6UP;W)T('-T9"YS=&1I;SL-"BL-"B!C;&%S<R!/=71/9DUE
M"BT)<')I;G1F*")/=70 ;V8 ;65M;W)Y7&XB*3L-"BL)=W)I=&5F*")/=70
M;V8 ;65M;W)Y7&XB*3L-"B (" ?0T*('T-"B -"F1I9F8 +75R(&1M9"]S
M<F,O<&AO8F]S+W-T9"]S;V-K970N9"!D;60O<W)C+W!H;V)O<U]N974O<W1D
M+W-O8VME="YD"BTM+2!D;60O<W)C+W!H;V)O<R]S=&0O<V]C:V5T+F0),C P
M-"TP.2TR,2 Q.3HQ-#HU.
M<&AO8F]S7VYE=2]S=&0O<V]C:V5T+F0),C P-"TQ,"TP-B P,CHR-3HQ,BXU
M( HM:6UP;W)T('-T9"YS=')I;F<L('-T9"YS=&1I;G0L('-T9"YC+G-T9&QI
M8CL**VEM<&]R="!S=&0N<W1R:6YG+"!S=&0N<W1D:6YT+"!S=&0N8RYS=&1L
M:6(L('-T9"YS=&1I;SL*( H "B!V97)S:6]N*%=I;C,R*0I 0" M-#DQ
M*S0Y,2PW($! "B!["B )26YT97)N971(;W-T(&EH(#T ;F5W($EN=&5R;F5T
M2&]S=#L*( EA<W-E<G0H:6 N9V5T2&]S=$)Y3F%M92 B=W=W+F1I9VET86QM
M87)S+F-O;2(I*3L*+0EP<FEN=&8H(F%D9'),:7-T+FQE;F=T:" ]("5D7&XB
M+"!I:"YA9&1R3&ES="YL96YG=& I.PHK"7=R:71E9B B861D<DQI<W0N;&5N
M9W1H(#T (BP :6 N861D<DQI<W0N;&5N9W1H+" B7&XB*3L*( EA<W-E<G0H
M:6 N861D<DQI<W0N;&5N9W1H*3L*( E);G1E<FYE=$%D9')E<W, :6$ /2!N
M97< 26YT97)N971!9&1R97-S*&EH+F%D9'),:7-T6S!=+"!);G1E<FYE=$%D
M9')E<W,N4$]25%]!3EDI.PH "7!R:6YT9B B25 861D<F5S<R ]("4N*G-<
M;FYA;64 /2 E+BIS7&XB+"!I82YT;T%D9')3=')I;F<H*2P :6 N;F%M92D[
M("4N*G-<;B(L(&DL(',I.PH "7T*( D*+0EP<FEN=&8H(BTM+5QN(BD["BL)
M=W)I=&5F*"(M+2U<;B(I.PH "0H "6%S<V5R="AI:"YG971(;W-T0GE!9&1R
M*&EH+F%D9'),:7-T6S!=*2D["B )<')I;G1F*")N86UE(#T )2XJ<UQN(BP
M:6 N;F%M92D["F1I9F8 +75R(&1M9"]S<F,O<&AO8F]S+W-T9"]S=VET8VAE
M<G(N9"!D;60O<W)C+W!H;V)O<U]N974O<W1D+W-W:71C:&5R<BYD"BTM+2!D
M;60O<W)C+W!H;V)O<R]S=&0O<W=I=&-H97)R+F0),C P-"TP.2TR,2 Q.3HQ
M-#HU.
M=&0O<W=I=&-H97)R+F0),C P-"TQ,"TP-B P,CHR-3HQ,BXU-S,Q-3DW-C
M9F%U;'0 )7,H)74I7&XB+"!C87-T*&-H87( *BEF:6QE;F%M92P ;&EN;G5M
M*3L-"BL)=W)I=&5F*")3=VET8V 1&5F875L=" B+"!F:6QE;F%M92P (B B
M+"!L:6YN=6TL("(I7&XB*3L-"B (" ?0T*('T-"B -"F1I9F8 +75R(&1M
M9"]S<F,O<&AO8F]S+W-T9"]T:')E860N9"!D;60O<W)C+W!H;V)O<U]N974O
M<W1D+W1H<F5A9"YD"BTM+2!D;60O<W)C+W!H;V)O<R]S=&0O=&AR96%D+F0)
M,C P-"TP.2TR,2 Q.3HQ-#HU.
M<F,O<&AO8F]S7VYE=2]S=&0O=&AR96%D+F0),C P-"TQ,"TP-B P,CHR-3HQ
M=6<]=&AR96%D.PT*( T**W!R:79A=&4 :6UP;W)T('-T9"YS=&1I;SL-"BL-
M"B O*B ]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/2!7:6XS,B ]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T *B\-"B -"B!V97)S
M;F< =&AR96%D("(L('0N:61X+" B7&XB*3L-"B )="YS=&%C:T)O='1O;2 ]
M"7T-"B -"BT)9&5B=6< *'1H<F5A9"D <')I;G1F*")%;F1I;F< =&AR96%D
M:61X(#T
M"B )?0T*+0EP<FEN=&8H(F1I9&XG="!F:6YD(&ET7&XB*3L-"BL)=W)I=&5F
M*'1H<F5A9"D <')I;G1F*")%;F1I;F< =&AR96%D("5D7&XB+"!T+FED>"D[
M("UU<B!D;60O<W)C+W!H;V)O<R]S=&0O=71F+F0 9&UD+W-R8R]P:&]B;W-?
M;F5U+W-T9"]U=&8N9 HM+2T 9&UD+W-R8R]P:&]B;W,O<W1D+W5T9BYD"3(P
M,34Y-S8P("LP,C P"D! ("TU-BPW("LU-BPW($! "B -"B!U;FET=&5S= T*
M('L-"BT (" 9&5B=6<H=71F*2!P<FEN=&8H(G5T9BYI<U9A;&ED1&-H87(N
M=6YI='1E<W1<;B(I.PT**R ("!D96)U9RAU=&8I('=R:71E9B B=71F+FES
M1&-H87(H8V%S="AD8VAA<BDG82<I(#T]('1R=64I.PT*(" ("!A<W-E<G0H
M:7-686QI9$1C:&%R*&-A<W0H9&-H87(I,' Q1D9&1D8I(#T](&9A;'-E*3L-
M<F,O<&AO8F]S7VYE=2]U;FET=&5S="YD"BTM+2!D;60O<W)C+W!H;V)O<R]U
M('1O(')U;B!T:&4 =6YI="!T97-T<R!O;B!T:&5M+ T*("\O(%1H96XL(&ET
M('!R:6YT<R!O=70 =&AE(&%R9W5M96YT<R!P87-S960 =&\ ;6%I;B I+ T*
M( T*+6EM<&]R="!S=&0N8RYS=&1I;SL-"BMI;7!O<G0 <W1D+G-T9&EO.PT*
M(&EM<&]R="!S=&0N<W1R:6YG.PT*(&EM<&]R="!S=&0N<&%T:#L-"B!I;7!O
M;F< :6X =6YI="!T97-T(&9O<B!M;V1U;&4 8GD <F5F97)E;F-I;F< 9G5N
M8W1I;VX :6X :70-"B -"B (" 8VUP*")F;V\B+" B8F%R(BD["0D)+R\
M(" :7-N86XH,2XP*3L)"0D)+R\ ;6%T: T*(" ("!F97$H,2XP+" R+C I
M.PDO+R!O=71B=69F97(-"B (" <W1D+F-T>7!E+G1O;&]W97(H)T$G*3L)
M;G0 85M=.PT*(" ("!A+G)E=F5R<V4["0D)"2\O(&%D:0T*(" ("!A+G-O
M(&-R96%L(&, /2 S+C *R T+C!I.PT*(" ("!C(#T <W%R="AC*3L-"BT
M(" <')I;G1F*")R92 ]("5,9RP :6T /2 E3&=<;B(L(&,N<F4L(&,N:6TI
M.PT**R ("!W<FET968H(G)E(#T (BP 8RYR92P (BP :6T /2 B+"!C+FEM
M.PT*+2 ("!P<FEN=&8H(F%R9W,N;&5N9W1H(#T )61<;B(L(&%R9W,N;&5N
M:71E9B B87)G<RYL96YG=& /2 B+"!A<F=S+FQE;F=T:"PB7&XB*3L-"B
M<FEN=&8H(F%R9W-;)61=(#T )R5S)UQN(BP :2P 8V%S="AC:&%R("HI87)G
M(F%R9W-;(BQI+")=(#T (BQA<F=S6VE=+")<;B(I.PT**R ("!W<FET968H
F(E-U8V-E<W-<;B%<;B(I.PT*(" ("!R971U<FX ,#L-
`
end
Oct 06 2004
Thomas Kuehne wrote:Replaced printf with writef in the release code of phobos. Most unittests still remain to be converted. Note: if you haven't applied the patch from digitalmars.com digitalmars.D.bugs:2025 you'll have to fix some chunks(missing "private" keyword). Thomasshouldn't writef(msg,"\n"); be writefln("",msg); otherwise the msg gets parsed as a format string.
Oct 06 2004
Ben Hinkle wrote:Thomas Kuehne wrote:What's wrong with writefln(msg); ? Stewart.Replaced printf with writef in the release code of phobos. Most unittests still remain to be converted. Note: if you haven't applied the patch from digitalmars.com digitalmars.D.bugs:2025 you'll have to fix some chunks(missing "private" keyword). Thomasshouldn't writef(msg,"\n"); be writefln("",msg); otherwise the msg gets parsed as a format string.
Oct 06 2004
Ben Hinkle <bhinkle4 juno.com> Stewart Gordon wrote:Ben Hinkle wrote:I haven't actually tried it but yeah that might work as long as there aren't any parameters. I don't know if writef errors when it sees writef("%s") with an error saying not enough parameters or if it prints the string "%s". To be consistent it should error but I don't know what it actually does. -BenThomas Kuehne wrote:What's wrong with writefln(msg); ? Stewart.Replaced printf with writef in the release code of phobos. Most unittests still remain to be converted. Note: if you haven't applied the patch from digitalmars.com digitalmars.D.bugs:2025 you'll have to fix some chunks(missing "private" keyword). Thomasshouldn't writef(msg,"\n"); be writefln("",msg); otherwise the msg gets parsed as a format string.
Oct 06 2004
Stewart Gordon wrote: <snip>Oops, that wasn't what I meant to say. You misunderstand how writef works. Unlike printf, writef doesn't just take its first argument to be a format string. Instead, it takes the first string it encounters to be a format string. It then reads as many arguments as the format string specifies. After it has done this, it reads subsequent argument strings in the same way, which may include another format string. And so either writefln("", msg); or writefln(msg); will cause msg to be interpreted as a format string. OTOH, if you write writefln("%s", msg); then msg is a field of the format string "%s". Hence msg will not be parsed as a format string. Stewart.shouldn't writef(msg,"\n"); be writefln("",msg); otherwise the msg gets parsed as a format string.What's wrong with writefln(msg);
Oct 06 2004
Stewart Gordon schrieb:
Instead, it takes the first string it encounters to be a format string.
It then reads as many arguments as the format string specifies. After
it has done this, it reads subsequent argument strings in the same way,
which may include another format string.
And so either
writefln("", msg);
or
writefln(msg);
will cause msg to be interpreted as a format string. OTOH, if you write
writefln("%s", msg);
then msg is a field of the format string "%s". Hence msg will not be
parsed as a format string.
I forgot that :O
Thomas
Oct 07 2004
On Wed, 06 Oct 2004 13:08:48 +0100, Stewart Gordon wrote:Ben Hinkle wrote:The first parameter is supposed to be a template or pattern, thus if 'msg' just happens to contain formatting codes, the application may abort. It is safer to do ... writefln("%s", msg); I tested 'writefln("%s")' and I got the error message "Error: std.format". -- Derek Melbourne, AustraliaThomas Kuehne wrote:What's wrong with writefln(msg); ? Stewart.Replaced printf with writef in the release code of phobos. Most unittests still remain to be converted. Note: if you haven't applied the patch from digitalmars.com digitalmars.D.bugs:2025 you'll have to fix some chunks(missing "private" keyword). Thomasshouldn't writef(msg,"\n"); be writefln("",msg); otherwise the msg gets parsed as a format string.
Oct 06 2004