www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.announce - Voting for std.experimental.allocator

reply "Dicebot" <public dicebot.lv> writes:
Andrei is back online and thus it is time to make a decision 
about adding his allocator package 
(http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

Docs: 
http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html
Code: 
https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator

Please respond to this post with a comment starting with a single 
"Yes"/"No" and optional explanation after that. Criteria you are 
expected to evaluate as part of "Yes":

- is this functionality needed in Phobos
- is basic design sound (some breaking changes are OK for 
std.experimental but not full redesign)

As usual, anyone can vote, but opinions of Phobos developers hold 
more value.

Voting ends in 2 weeks, on July 22.
Jul 08 2015
next sibling parent Rikki Cattermole <alphaglosined gmail.com> writes:
On 8/07/2015 11:33 p.m., Dicebot wrote:
 Andrei is back online and thus it is time to make a decision about
 adding his allocator package
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to
 Phobos std.experimental

 Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html
 Code:
 https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator


 Please respond to this post with a comment starting with a single
 "Yes"/"No" and optional explanation after that. Criteria you are
 expected to evaluate as part of "Yes":

 - is this functionality needed in Phobos
 - is basic design sound (some breaking changes are OK for
 std.experimental but not full redesign)

 As usual, anyone can vote, but opinions of Phobos developers hold more
 value.

 Voting ends in 2 weeks, on July 22.
Yes. I do have opinions about it, i.e. it doesn't feel 100% right especially from work with std.experimental.image. However it is needed and I do not believe that it has any major issues. It's just smallish things that I cannot quite put my finger on.
Jul 08 2015
prev sibling next sibling parent "Robert burner Schadek" <rburners gmail.com> writes:
Yes
Jul 08 2015
prev sibling next sibling parent "wobbles" <grogan.colin gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes. I think getting it into std.experimental is important to get more people to test it for sound design.
Jul 08 2015
prev sibling next sibling parent "ponce" <contact gam3sfrommars.fr> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Please respond to this post with a comment starting with a 
 single "Yes"/"No" and optional explanation after that. Criteria 
 you are expected to evaluate as part of "Yes":
Yes.
Jul 08 2015
prev sibling next sibling parent "Jack Stouffer" <jack jackstouffer.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Please respond to this post with a comment starting with a 
 single "Yes"/"No"
Yes
Jul 08 2015
prev sibling next sibling parent Dmitry Olshansky <dmitry.olsh gmail.com> writes:
Yes


-- 
Dmitry Olshansky
Jul 08 2015
prev sibling next sibling parent "Adam D. Ruppe" <destructionator gmail.com> writes:
yeah
Jul 08 2015
prev sibling next sibling parent "ZombineDev" <valid_email he.re> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes
Jul 08 2015
prev sibling next sibling parent Justin Whear <justin economicmodeling.com> writes:
Yes.
Jul 08 2015
prev sibling next sibling parent "Mike Parker" <aldacron gmail.com> writes:
yes
Jul 08 2015
prev sibling next sibling parent "John Colvin" <john.loughran.colvin gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes Having an official set of allocators - breaking changes or no - is a great step.
Jul 08 2015
prev sibling next sibling parent "HaraldZealot" <harald_zealot tut.by> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes
Jul 08 2015
prev sibling next sibling parent "extrawurst" <stephan extrawurst.org> writes:
yes
Jul 08 2015
prev sibling next sibling parent =?UTF-8?B?Ik5vcmRsw7Z3Ig==?= <per.nordlow gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Please respond to this post with a comment starting with a 
 single "Yes"/"No"
Yes
Jul 08 2015
prev sibling next sibling parent "MrSmith" <mrsmith33 yandex.ru> writes:
Yes
Jul 08 2015
prev sibling next sibling parent "Brian Schott" <briancschott gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Please respond to this post with a comment starting with a 
 single "Yes"/"No" and optional explanation after that.
Yes.
Jul 08 2015
prev sibling next sibling parent "Mike" <none none.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Please respond to this post with a comment starting with a 
 single "Yes"/"No" and optional explanation after that.
Yes
Jul 08 2015
prev sibling next sibling parent "Philpax" <me philpax.me> writes:
Yes.
Jul 08 2015
prev sibling next sibling parent "Atila Neves" <atila.neves gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes.
Jul 09 2015
prev sibling next sibling parent reply "Alex Parrill" <initrd.gz gmail.com> writes:
Yes, but the mmap allocator on Windows needs to be fixed.
Jul 09 2015
parent reply Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 7/9/15 5:44 PM, Alex Parrill wrote:
 Yes, but the mmap allocator on Windows needs to be fixed.
What is the issue with it? I recall I pulled something recently. -- Andrei
Jul 10 2015
parent reply "Alex Parrill" <initrd.gz gmail.com> writes:
On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu 
wrote:
 On 7/9/15 5:44 PM, Alex Parrill wrote:
 Yes, but the mmap allocator on Windows needs to be fixed.
What is the issue with it? I recall I pulled something recently. -- Andrei
It leaks. http://forum.dlang.org/post/itmcarskypkuospvfvbp forum.dlang.org
Jul 10 2015
parent reply Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 7/10/15 4:29 PM, Alex Parrill wrote:
 On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu wrote:
 On 7/9/15 5:44 PM, Alex Parrill wrote:
 Yes, but the mmap allocator on Windows needs to be fixed.
What is the issue with it? I recall I pulled something recently. -- Andrei
It leaks. http://forum.dlang.org/post/itmcarskypkuospvfvbp forum.dlang.org
I see. Could you or someone with Windows expertise create a PR for my branch? -- Andrei
Jul 10 2015
parent Dmitry Olshansky <dmitry.olsh gmail.com> writes:
On 11-Jul-2015 01:51, Andrei Alexandrescu wrote:
 On 7/10/15 4:29 PM, Alex Parrill wrote:
 On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu wrote:
 On 7/9/15 5:44 PM, Alex Parrill wrote:
 Yes, but the mmap allocator on Windows needs to be fixed.
What is the issue with it? I recall I pulled something recently. -- Andrei
It leaks. http://forum.dlang.org/post/itmcarskypkuospvfvbp forum.dlang.org
I see. Could you or someone with Windows expertise create a PR for my branch? -- Andrei
This one? :) https://github.com/andralex/phobos/pull/17 -- Dmitry Olshansky
Jul 10 2015
prev sibling next sibling parent Alix Pexton <alix.DOT.pexton gmail.DOT.com> writes:
Yes!
Jul 10 2015
prev sibling next sibling parent Daniel Kozak via Digitalmars-d-announce writes:
On Wed, 08 Jul 2015 11:33:01 +0000
Dicebot via Digitalmars-d-announce <digitalmars-d-announce puremagic.com> wrote:

 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
 std.experimental
 
 Docs: 
 http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html
 Code: 
 https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator
 
 Please respond to this post with a comment starting with a single 
 "Yes"/"No" and optional explanation after that. Criteria you are 
 expected to evaluate as part of "Yes":
 
 - is this functionality needed in Phobos
 - is basic design sound (some breaking changes are OK for 
 std.experimental but not full redesign)
 
 As usual, anyone can vote, but opinions of Phobos developers hold 
 more value.
 
 Voting ends in 2 weeks, on July 22.
Yes
Jul 11 2015
prev sibling next sibling parent reply "Dicebot" <public dicebot.lv> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Voting ends in 2 weeks, on July 22.
~1 week remains
Jul 16 2015
parent "Uranuz" <neuranuz gmail.com> writes:
On Thursday, 16 July 2015 at 10:02:17 UTC, Dicebot wrote:
 On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Voting ends in 2 weeks, on July 22.
~1 week remains
Yes. It's time to have this functionality in standart library.
Jul 16 2015
prev sibling next sibling parent "Dicebot" <public dicebot.lv> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Voting ends in 2 weeks, on July 22.
Voting ends tomorrow. At this point it is almost impossible to fail so it is up to Phobos team how to proceed with the PR.
Jul 21 2015
prev sibling next sibling parent "Dejan Lekic" <dejan.lekic gmail.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 Docs: 
 http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html
 Code: 
 https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator

 Please respond to this post with a comment starting with a 
 single "Yes"/"No" and optional explanation after that. Criteria 
 you are expected to evaluate as part of "Yes":

 - is this functionality needed in Phobos
 - is basic design sound (some breaking changes are OK for 
 std.experimental but not full redesign)

 As usual, anyone can vote, but opinions of Phobos developers 
 hold more value.

 Voting ends in 2 weeks, on July 22.
Yes.
Jul 22 2015
prev sibling next sibling parent "Joseph Cassman" <jc7919 outlook.com> writes:
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote:
 Andrei is back online and thus it is time to make a decision 
 about adding his allocator package 
 (http://forum.dlang.org/post/vfipmwojmvseqxoiwndr forum.dlang.org) to Phobos
std.experimental

 [...]
Yes
Jul 22 2015
prev sibling parent "Dicebot" <public dicebot.lv> writes:
Final stats:

Yes - 25
No - 0

Quite a definitive approval. http://wiki.dlang.org/Review_Queue 
log has been updated.

With this formal review of std.experimental.allocator is 
considered finished.
Jul 25 2015