• deadalnix (3/3) Jun 26 2016 Several people during DConf asked abut tips and tricks on code
• Walter Bright (2/3) Jun 27 2016 Nice article!
• Steven Schveighoffer (4/7) Jun 27 2016 Very nice. One thing missing: Always remember to update documentation
• Johan Engelen (13/16) Jun 27 2016 It's a nice read.
• Andrei Alexandrescu (4/7) Jun 28 2016 Nice work. Let's see:

deadalnix <deadalnix gmail.com> writes:

Several people during DConf asked abut tips and tricks on code 
review. So I wrote an article about it:

http://www.deadalnix.me/2016/06/27/on-code-review/

Walter Bright <newshound2 digitalmars.com> writes:

On 6/26/2016 5:01 PM, deadalnix wrote:
 http://www.deadalnix.me/2016/06/27/on-code-review/

Nice article!

Steven Schveighoffer <schveiguy yahoo.com> writes:

On 6/26/16 8:01 PM, deadalnix wrote:
 Several people during DConf asked abut tips and tricks on code review.
 So I wrote an article about it:

 http://www.deadalnix.me/2016/06/27/on-code-review/

Very nice. One thing missing: Always remember to update documentation 
when submitting updates! Can probably be lumped together with tests section.

-Steve

Johan Engelen <j j.nl> writes:

On Monday, 27 June 2016 at 00:01:34 UTC, deadalnix wrote:
 Several people during DConf asked abut tips and tricks on code 
 review. So I wrote an article about it:

 http://www.deadalnix.me/2016/06/27/on-code-review/

It's a nice read.

One comment: perhaps the balance has tipped a bit much to "making 
a good PR", rather than "doing a good review". I feel the merit 
of a review is to improve the contribution, rather than to decide 
whether it is mergable or not.  Although it is in the article, I 
think it could be given a little more attention: the review 
itself should contribute to the project, i.e. the reviewer should 
(try hard to) propose alternatives if something should/could be 
improved. Criticism is very easy, _constructive_ criticism isn't; 
I think the latter is needed to gain a contributor, and the first 
does the opposite.

-Johan

Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:

On 6/26/16 8:01 PM, deadalnix wrote:
 Several people during DConf asked abut tips and tricks on code review.
 So I wrote an article about it:

 http://www.deadalnix.me/2016/06/27/on-code-review/

Nice work. Let's see: 
https://www.reddit.com/r/programming/comments/4q9fl5/on_code_review/ -- 
Andrei