digitalmars.D - Trivial Pull Requests
- Walter Bright (10/10) Jul 03 2016 There was a "Trivial" label on dlang/dmd, and I added it to dlang/drunti...
- Mathias Lang via Digitalmars-d (7/18) Jul 03 2016 Labels can only be applied by contributors, in other words people with
- Basile B. (6/11) Jul 03 2016 You should use "member" instead of "contributor", actually a
- Walter Bright (3/9) Jul 03 2016 That works, too.
There was a "Trivial" label on dlang/dmd, and I added it to dlang/druntime and dlang/phobos. Please use it to tag trivial pull requests, so that they can be quickly checked and merged. A trivial PR should be: 1. really easy to review 2. highly unlikely to break anything, i.e. its effects are clearly constrained An example would be something like fixing a spelling error. If a trivial PR is not trivial, please remove the label with a note explaining why it isn't trivial.
Jul 03 2016
Labels can only be applied by contributors, in other words people with merge access. So this is only useful for P.R. made by contributors. I doubt a contributor seeing a trivial P.R. (made by a non-contributor) will label it, instead of just pulling the auto-merge trigger. So I'll stick with `[Trivial]` in the P.R. title. 2016-07-04 0:55 GMT+02:00 Walter Bright via Digitalmars-d < digitalmars-d puremagic.com>:There was a "Trivial" label on dlang/dmd, and I added it to dlang/druntime and dlang/phobos. Please use it to tag trivial pull requests, so that they can be quickly checked and merged. A trivial PR should be: 1. really easy to review 2. highly unlikely to break anything, i.e. its effects are clearly constrained An example would be something like fixing a spelling error. If a trivial PR is not trivial, please remove the label with a note explaining why it isn't trivial.
Jul 03 2016
On Monday, 4 July 2016 at 00:27:45 UTC, Mathias Lang wrote:Labels can only be applied by contributors, in other words people with merge access. So this is only useful for P.R. made by contributors. I doubt a contributor seeing a trivial P.R. (made by a non-contributor)You should use "member" instead of "contributor", actually a contributor is what you call a "non-contributor" and what you call a contributor is a "member" or "dlang member". With you naming fashion, a "non-contributor" means nothing...because actually "non-contributors" contribute...you see what i mean...
Jul 03 2016
On 7/3/2016 5:27 PM, Mathias Lang via Digitalmars-d wrote:Labels can only be applied by contributors, in other words people with merge access. So this is only useful for P.R. made by contributors.I didn't know that.I doubt a contributor seeing a trivial P.R. (made by a non-contributor) will label it, instead of just pulling the auto-merge trigger. So I'll stick with `[Trivial]` in the P.R. title.That works, too.
Jul 03 2016