www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Request for approval: deploying dlang.org on merge

reply Seb <seb wilzba.ch> writes:
Hey,


Let me tell you a little story - once there was the amazing Dconf 
at the beginning of this month (4-6.5).

We put a notice about it on dlang.org "DConf 2016 is coming up: 
May 4-6 in Berlin, Germany. Secure your seat before it's sold 
out!".

It took two weeks, but finally karthikeyan had the time to shout 
and report the outdated message [1].

The PR was merged subsequentially quite fast, but this was more 
than a weeek ago and we still have the annoucement about DConf on 
our landing page.

I talked with CyberShadow a bit, because setting up a CI and 
deploying the website automatically on a merge doesn't seem 
difficult and to quote him the main problem is approval:


 We already have 
 http://wiki.dlang.org/User:Vladimir_Panteleev/Website_staging 
 so it's not a matter of implementation, just everyone agreeing 
 that it's what we want to do


Imho it makes a lot of sense to do this, because showing such 
horribly (>=more than three weeks) outdated news on dlang.org 
makes a terrible impression and merging something should be the 
approval, not the huge latency of our dlang.org maintainer (no 
offense).

If you are against this automatic deployment or want to do it 
manually yourself, please shout now.

[1] https://issues.dlang.org/show_bug.cgi?id=16040
[2] https://github.com/dlang/dlang.org/pull/1304
May 26 2016
next sibling parent reply Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 5/26/16 11:53 AM, Seb wrote:

 Hey,


 Let me tell you a little story - once there was the amazing Dconf at the
 beginning of this month (4-6.5).

 We put a notice about it on dlang.org "DConf 2016 is coming up: May 4-6
 in Berlin, Germany. Secure your seat before it's sold out!".

 It took two weeks, but finally karthikeyan had the time to shout and
 report the outdated message [1].

 The PR was merged subsequentially quite fast, but this was more than a
 weeek ago and we still have the annoucement about DConf on our landing
 page.

 I talked with CyberShadow a bit, because setting up a CI and deploying
 the website automatically on a merge doesn't seem difficult and to quote
 him the main problem is approval:


 We already have
 http://wiki.dlang.org/User:Vladimir_Panteleev/Website_staging so it's
 not a matter of implementation, just everyone agreeing that it's what
 we want to do


 Imho it makes a lot of sense to do this, because showing such horribly
 (>=more than three weeks) outdated news on dlang.org makes a terrible
 impression and merging something should be the approval, not the huge
 latency of our dlang.org maintainer (no offense).

 If you are against this automatic deployment or want to do it manually
 yourself, please shout now.

 [1] https://issues.dlang.org/show_bug.cgi?id=16040
 [2] https://github.com/dlang/dlang.org/pull/1304


If Vladimir is okay with auto-deployment I'm okay too. Move fast! The 
only question is, how do we avoid cases in which a deployment breaks 
something important? -- Andrei
May 26 2016
next sibling parent reply Dicebot <public dicebot.lv> writes:
On Thursday, 26 May 2016 at 16:38:16 UTC, Andrei Alexandrescu 
wrote:

 If Vladimir is okay with auto-deployment I'm okay too. Move 
 fast! The only question is, how do we avoid cases in which a 
 deployment breaks something important? -- Andrei


You don't need to avoid - just hit "revert" button and rely on 
auto-deploy of reverted version.
May 26 2016
parent Seb <seb wilzba.ch> writes:
On Thursday, 26 May 2016 at 16:43:20 UTC, Dicebot wrote:

 On Thursday, 26 May 2016 at 16:38:16 UTC, Andrei Alexandrescu 
 wrote:

 If Vladimir is okay with auto-deployment I'm okay too. Move 
 fast! The only question is, how do we avoid cases in which a 
 deployment breaks something important? -- Andrei


 You don't need to avoid - just hit "revert" button and rely on 
 auto-deploy of reverted version.


Moreover we have Vladimir's DAutoTest that allows us to preview 
every PR, s.t.
chances that we merge such a PR are low ;-)
May 26 2016
prev sibling parent reply Vladimir Panteleev <thecybershadow.lists gmail.com> writes:
On Thursday, 26 May 2016 at 16:38:16 UTC, Andrei Alexandrescu 
wrote:

 If Vladimir is okay with auto-deployment I'm okay too. Move 
 fast!


This is now live. (Perhaps it should be posted in Announce?)


 The only question is, how do we avoid cases in which a 
 deployment breaks something important? -- Andrei


1. Check the documentation tester results before merging 
anything. This also applies to other components (Phobos, 
Druntime, DMD) though most changes there are unlikely to break 
things.
2. If something breaks, make and merge a PR which reverts or 
fixes it. Pushing directly to master would also work, but 
wouldn't make a big difference in practice.
3. If that doesn't work, people with access can always ssh to 
dlang k3.1azy.net or dlang.org to fix things by hand.
Jun 03 2016
parent Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 06/03/2016 05:43 PM, Vladimir Panteleev wrote:

 On Thursday, 26 May 2016 at 16:38:16 UTC, Andrei Alexandrescu wrote:

 If Vladimir is okay with auto-deployment I'm okay too. Move fast!


 This is now live. (Perhaps it should be posted in Announce?)


This is awesome, thank you guys for making it happen!


 The only question is, how do we avoid cases in which a deployment
 breaks something important? -- Andrei


 1. Check the documentation tester results before merging anything. This
 also applies to other components (Phobos, Druntime, DMD) though most
 changes there are unlikely to break things.
 2. If something breaks, make and merge a PR which reverts or fixes it.
 Pushing directly to master would also work, but wouldn't make a big
 difference in practice.
 3. If that doesn't work, people with access can always ssh to
 dlang k3.1azy.net or dlang.org to fix things by hand.


Sounds like a good seed for a wiki page.


Andrei
Jun 04 2016
prev sibling parent reply Jesse Phillips <Jesse.K.Phillips+D gmail.com> writes:
On Thursday, 26 May 2016 at 15:53:34 UTC, Seb wrote:

 We already have 
 http://wiki.dlang.org/User:Vladimir_Panteleev/Website_staging 
 so it's not a matter of implementation, just everyone agreeing 
 that it's what we want to do




Would this mean the website always reflects Phobos HEAD? Is that 
what the docs currently do?

This probably shouldn't stop making the switch, more a reminder 
that we don't reflect the release version of DMD.
May 27 2016
parent reply Joakim <dlang joakim.fea.st> writes:
On Friday, 27 May 2016 at 14:34:03 UTC, Jesse Phillips wrote:

 On Thursday, 26 May 2016 at 15:53:34 UTC, Seb wrote:

 We already have 
 http://wiki.dlang.org/User:Vladimir_Panteleev/Website_staging 
 so it's not a matter of implementation, just everyone 
 agreeing that it's what we want to do




 Would this mean the website always reflects Phobos HEAD? Is 
 that what the docs currently do?


They're talking about the dlang.org repo, which doesn't contain 
phobos docs.  Those are statically generated from the source.


 This probably shouldn't stop making the switch, more a reminder 
 that we don't reflect the release version of DMD.


The language spec _is_ stored in that repo, but I don't think it 
has been kept in sync with the release version, ie only updated 
with a new dmd release.
May 27 2016
parent Steven Schveighoffer <schveiguy yahoo.com> writes:
On 5/27/16 11:35 AM, Joakim wrote:

 On Friday, 27 May 2016 at 14:34:03 UTC, Jesse Phillips wrote:

 On Thursday, 26 May 2016 at 15:53:34 UTC, Seb wrote:

 We already have
 http://wiki.dlang.org/User:Vladimir_Panteleev/Website_staging so
 it's not a matter of implementation, just everyone agreeing that
 it's what we want to do




 Would this mean the website always reflects Phobos HEAD? Is that what
 the docs currently do?


 They're talking about the dlang.org repo, which doesn't contain phobos
 docs.  Those are statically generated from the source.


This should be done for both dlang.org, and phobos+druntime, and should 
reflect the stable branch for both.

Totally in favor of this!

-Steve
May 27 2016