www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Rebasing of PRs

reply Nicholas Wilson <iamthewilsonator hotmail.com> writes:
Some of you may have noticed that I have been merging a lot of 
Old PRs recently.

Due to some old CI bugs and other bitrot and PRs merged, many 
outstanding PRs need a rebase.

If you have an open PR in dmd or druntime marked `needs rebase` 
(if they're really old it may be better to close it and open a 
new one, it will be a long time before the CI gets to it) or a 
dlang.org PR that is not green, please do me a favour and rebase 
it and ping me when you do.

Many Thanks
Nic
Nov 09 2018
next sibling parent reply Walter Bright <newshound2 digitalmars.com> writes:
On 11/9/2018 1:49 AM, Nicholas Wilson wrote:
 Some of you may have noticed that I have been merging a lot of Old PRs
recently.
 
 Due to some old CI bugs and other bitrot and PRs merged, many outstanding PRs 
 need a rebase.
 
 If you have an open PR in dmd or druntime marked `needs rebase` (if they're 
 really old it may be better to close it and open a new one, it will be a long 
 time before the CI gets to it) or a dlang.org PR that is not green, please do
me 
 a favour and rebase it and ping me when you do.
Could you please mark the ones you plan to merge with the "72 hr" tag beforehand?
Nov 09 2018
parent Nicholas Wilson <iamthewilsonator hotmail.com> writes:
On Friday, 9 November 2018 at 21:16:47 UTC, Walter Bright wrote:
 On 11/9/2018 1:49 AM, Nicholas Wilson wrote:
 Some of you may have noticed that I have been merging a lot of 
 Old PRs recently.
 
 Due to some old CI bugs and other bitrot and PRs merged, many 
 outstanding PRs need a rebase.
 
 If you have an open PR in dmd or druntime marked `needs 
 rebase` (if they're really old it may be better to close it 
 and open a new one, it will be a long time before the CI gets 
 to it) or a dlang.org PR that is not green, please do me a 
 favour and rebase it and ping me when you do.
Could you please mark the ones you plan to merge with the "72 hr" tag beforehand?
Sorry about that one. Stefan said he wanted to take a look at it and there were another few PRs also on auto merge.
Nov 09 2018
prev sibling parent reply Rubn <where is.this> writes:
On Friday, 9 November 2018 at 09:49:39 UTC, Nicholas Wilson wrote:
 Some of you may have noticed that I have been merging a lot of 
 Old PRs recently.

 Due to some old CI bugs and other bitrot and PRs merged, many 
 outstanding PRs need a rebase.

 If you have an open PR in dmd or druntime marked `needs rebase` 
 (if they're really old it may be better to close it and open a 
 new one, it will be a long time before the CI gets to it) or a 
 dlang.org PR that is not green, please do me a favour and 
 rebase it and ping me when you do.

 Many Thanks
 Nic
I made a PR once, it sat long enough that it needed a rebase, which I did. Then it sat so long again that it needed another one. I lost interest as a result of dlang's lack of interest and now I'm pretty sure it's one of those that needs a rebase again. Why the fuck should I or anyone else bother? It's a mess that was created due to lack of management. And certain individuals refuse to acknowledge said issue as they pull up stats on how many pull requests get merged in (basically just the ones that the dlang team merge on their own due to their connections).
Nov 10 2018
parent Nicholas Wilson <iamthewilsonator hotmail.com> writes:
On Sunday, 11 November 2018 at 01:13:51 UTC, Rubn wrote:
 I made a PR once, it sat long enough that it needed a rebase, 
 which I did. Then it sat so long again that it needed another 
 one. I lost interest as a result of dlang's lack of interest 
 and now I'm pretty sure it's one of those that needs a rebase 
 again.
repo name would help a lot.
Why the fuck should I or anyone else bother? It's a mess
 that was created due to lack of management.
Aye. But I am now the Pull Request manager[1], so things are moving forward.
 And certain individuals refuse to acknowledge said issue as 
 they pull up stats on how many pull requests get merged in 
 (basically just the ones that the dlang team merge on their own 
 due to their connections).
I'm not denying we have a problem with rotting PRs, but I have merged a large number of PRs over the last few days and will continue to do so. Yes there are still lots to go, but they can't all be merged at once (not the least of which is that the CIs are not that fast), but I do very much hope to get there. [1]:https://forum.dlang.org/thread/swsfgggaawgylauuzjlm forum.dlang.org
Nov 10 2018