digitalmars.D - Procedural Question for Pull Requests
- Adam Wilson (10/10) May 26 2014 Hi everyone,
- Daniel Murphy (2/8) May 26 2014 As needed, as small as possible.
- Walter Bright (2/3) May 26 2014 Right. The smaller they are, the easier they are to review.
- Adam Wilson (7/10) May 26 2014 Done. I look forward to some easy stats karma then. ;-)
Hi everyone, I have a small procedural question regarding pull requests against druntime's operating system interfaces. Specifically I may find it quite useful to add Windows API function calls and types to the core.sys.windows.windows file. Should I pull them as needed or bunch them up and do a larger pull later? -- Adam Wilson GitHub/IRC: LightBender Aurora Project Coordinator
May 26 2014
"Adam Wilson" wrote in message news:op.xghyetkm707hn8 invictus.hra.local...Hi everyone, I have a small procedural question regarding pull requests against druntime's operating system interfaces. Specifically I may find it quite useful to add Windows API function calls and types to the core.sys.windows.windows file. Should I pull them as needed or bunch them up and do a larger pull later?As needed, as small as possible.
May 26 2014
On 5/26/2014 8:14 PM, Daniel Murphy wrote:As needed, as small as possible.Right. The smaller they are, the easier they are to review.
May 26 2014
On Mon, 26 May 2014 21:20:09 -0700, Walter Bright <newshound2 digitalmars.com> wrote:On 5/26/2014 8:14 PM, Daniel Murphy wrote:Done. I look forward to some easy stats karma then. ;-) -- Adam Wilson GitHub/IRC: LightBender Aurora Project CoordinatorAs needed, as small as possible.Right. The smaller they are, the easier they are to review.
May 26 2014