www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - How can I help with pull requests if I don't have the authority to

reply "Atila Neves" <atila.neves gmail.com> writes:
After this thread:

http://forum.dlang.org/thread/hapxxhusoniimfxiefji forum.dlang.org

I had some time today and headed over to Github to see if I could 
help out. But I'm not sure what I can do if I don't have the 
power to approve PRs. I'm not asking for that power, I haven't 
earned it yet. I'm just asking what it is I can do to help, 
especially on PRs that already have comments from a bunch of 
people.

Should I add comments to the ones that don't? Work on my own PRs 
instead?

Atila
Jan 29 2015
next sibling parent Steven Schveighoffer <schveiguy yahoo.com> writes:
On 1/29/15 8:42 AM, Atila Neves wrote:

 After this thread:

 http://forum.dlang.org/thread/hapxxhusoniimfxiefji forum.dlang.org

 I had some time today and headed over to Github to see if I could help
 out. But I'm not sure what I can do if I don't have the power to approve
 PRs. I'm not asking for that power, I haven't earned it yet. I'm just
 asking what it is I can do to help, especially on PRs that already have
 comments from a bunch of people.

 Should I add comments to the ones that don't? Work on my own PRs instead?


Reviewing is available to everyone. In general, it takes 2 reviewers to 
approve a PR, but only one of those has to have commit capabilities. As 
long as we know 2 sets of eyes have seen it and approve, it doesn't 
matter that one of those sets doesn't have commit permissions.

H.S. Teoh ( quickfur) got his wings by reviewing and submitting PRs.

-Steve
Jan 29 2015
prev sibling next sibling parent Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 1/29/15 5:42 AM, Atila Neves wrote:

 After this thread:

 http://forum.dlang.org/thread/hapxxhusoniimfxiefji forum.dlang.org

 I had some time today and headed over to Github to see if I could help
 out. But I'm not sure what I can do if I don't have the power to approve
 PRs. I'm not asking for that power, I haven't earned it yet. I'm just
 asking what it is I can do to help, especially on PRs that already have
 comments from a bunch of people.

 Should I add comments to the ones that don't? Work on my own PRs instead?

 Atila


Yes to both. A review carries a lot of weight. New work is of course 
great but takes larger chunks of time. -- Andrei
Jan 29 2015
prev sibling next sibling parent "H. S. Teoh via Digitalmars-d" <digitalmars-d puremagic.com> writes:
On Thu, Jan 29, 2015 at 01:42:13PM +0000, Atila Neves via Digitalmars-d wrote:

 After this thread:
 
 http://forum.dlang.org/thread/hapxxhusoniimfxiefji forum.dlang.org
 
 I had some time today and headed over to Github to see if I could help
 out.  But I'm not sure what I can do if I don't have the power to
 approve PRs. I'm not asking for that power, I haven't earned it yet.
 I'm just asking what it is I can do to help, especially on PRs that
 already have comments from a bunch of people.
 
 Should I add comments to the ones that don't? Work on my own PRs
 instead?


[...]

You don't need commit privileges to review PR's. We need more eyes to
look at the code that's going into D, a lot more eyes. You can just
leave comments on the PR page, saying that you reviewed it and it looks
good to merge (LGTM), or if you find issues or flaws, point them out.
Similarly if you have an idea of how to improve the PR, suggest it.

Of course, you can't merge the PR unless you have commit privileges, but
generally speaking we're more short of reviewers than committers. We
need all the help we can get!


T

-- 
In order to understand recursion you must first understand recursion.
Jan 29 2015
prev sibling parent reply "Jakob Ovrum" <jakobovrum gmail.com> writes:
On Thursday, 29 January 2015 at 13:42:15 UTC, Atila Neves wrote:

 After this thread:

 http://forum.dlang.org/thread/hapxxhusoniimfxiefji forum.dlang.org

 I had some time today and headed over to Github to see if I 
 could help out. But I'm not sure what I can do if I don't have 
 the power to approve PRs. I'm not asking for that power, I 
 haven't earned it yet. I'm just asking what it is I can do to 
 help, especially on PRs that already have comments from a bunch 
 of people.


Although the Github tags aren't always kept up to date, this link 
might be useful when looking for patches that need review:

https://github.com/D-Programming-Language/phobos/labels/needs%20review


 Should I add comments to the ones that don't? Work on my own 
 PRs instead?


Well, the ones that don't have any review might benefit more from 
you looking over it, but people often miss things; the more 
review the merrier. Please comment whenever you feel you have 
something to add!

Equally for your own patches, if you feel you have something to 
add, whether a bug fix, documentation improvement or new 
functionality, please send a PR :)
Jan 29 2015
parent "Jakob Ovrum" <jakobovrum gmail.com> writes:
On Thursday, 29 January 2015 at 19:46:03 UTC, Jakob Ovrum wrote:

 Although the Github tags aren't always kept up to date, this 
 link might be useful when looking for patches that need review:

 https://github.com/D-Programming-Language/phobos/labels/needs%20review


Of course, ditto for the other D repositories.
Jan 29 2015