• Seb (9/26) Jun 29 2016 From the recent article "Why Google Stores Billions of Lines of
• Dechcaudron (3/6) Jun 29 2016 I second it. Hopefully this will turn out in a shorter review
• qznc (4/10) Jun 29 2016 Ha. I was toying with building something like this myself. Now
• sarn (8/9) Jun 30 2016 Not everything applies because Google doesn't host its repo on

Seb <seb wilzba.ch> writes:

 From the recent article "Why Google Stores Billions of Lines of 
Code in a Single Repository" a very interesting excerpt about 
their code ownership [1]:

 An important aspect of Google culture that encourages code 
 quality is the expectation that all code is reviewed before 
 being committed to the repository. Most developers can view and 
 propose changes to files anywhere across the entire 
 codebase—with the exception of a small set of highly 
 confidential code that is more carefully controlled. The risk 
 associated with developers changing code they are not deeply 
 familiar with is mitigated through the code-review process and 
 the concept of code ownership. The Google codebase is laid out 
 in a tree structure. Each and every directory has a set of 
 owners who control whether a change to files in their directory 
 will be accepted. Owners are typically the developers who work 
 on the projects in the directories in question. A change often 
 receives a detailed code review from one developer, evaluating 
 the quality of the change, and a commit approval from an owner, 
 evaluating the appropriateness of the change to their area of 
 the codebase.

How about doing something similar for Phobos?
On a related note Facebook open-sourced it's "mention-bot" [2] 
that could be helpful in case no owners are defined.

[1] 
http://cacm.acm.org/magazines/2016/7/204032-why-google-stores-billions-of-lines-of-code-in-a-single-repository/fulltext
[2] https://github.com/facebook/mention-bot

Dechcaudron <no-reply no-email.com> writes:

On Wednesday, 29 June 2016 at 20:06:18 UTC, Seb wrote:
 How about doing something similar for Phobos?
 On a related note Facebook open-sourced it's "mention-bot" [2] 
 that could be helpful in case no owners are defined.

I second it. Hopefully this will turn out in a shorter review 
process for Phobos' PRs

qznc <qznc web.de> writes:

On Wednesday, 29 June 2016 at 20:09:52 UTC, Dechcaudron wrote:
 On Wednesday, 29 June 2016 at 20:06:18 UTC, Seb wrote:
 How about doing something similar for Phobos?
 On a related note Facebook open-sourced it's "mention-bot" [2] 
 that could be helpful in case no owners are defined.

 I second it. Hopefully this will turn out in a shorter review 
 process for Phobos' PRs

Ha. I was toying with building something like this myself. Now 
Facebook beat me to it. mention-bot is not D, though. ;)

However, I'm not sure if "finding reviewers" is the bottleneck?

sarn <sarn theartofmachinery.com> writes:

On Wednesday, 29 June 2016 at 22:35:03 UTC, qznc wrote:
 However, I'm not sure if "finding reviewers" is the bottleneck?

Not everything applies because Google doesn't host its repo on 
Github (obviously), but code ownership works very well there.  It 
helps avoid the bystander effect, and encourages casual 
contributors (like bugfixers) because they know they have a 
specific person to ping.  As long as code ownership is a position 
of responsibility, not power, I think it's a good idea for most 
large software projects.